Better compare implementatio 10000 ns for numeric tower (autodiff #3.5) #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sritchie/diff_three #236 +/- ##
======================================================
Coverage ? 84.16%
======================================================
Files ? 79
Lines ? 8098
Branches ? 441
======================================================
Hits ? 6816
Misses ? 841
Partials ? 441 Continue to review full report at Codecov.
|
|
@littleredcomputer , merging this and a few of the less-brainy ones to drain the queue a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autodiff PRs exposed some weaknesses with our ability to compare numbers to each other in Clojurescript. I caught some of this stuff after I realized that by using
sg/realI would flex a lot of the cross-type comparisons.I also discovered
valueOfin Javascript, which allows us to compare, say, a wrappedDifferentialorExpressioninstance (holding a number) with a native number, using the native comparison operators!!