Only trigger tag replacement in nested calls (sug 8000 gested by GJS) #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 84.19% 84.16% -0.03%
==========================================
Files 81 81
Lines 8375 8405 +30
Branches 453 455 +2
==========================================
+ Hits 7051 7074 +23
- Misses 871 876 +5
- Partials 453 455 +2
Continue to review full report at Codecov.
|
sritchie
commented
Feb 1, 2021
| (fn [x] | ||
| (let [tag (d/fresh-tag) | ||
| lifted (d/bundle-element x 1 tag)] | ||
| (-> (d/with-active-tag tag f [lifted]) |
There was a problem hiding this comment.
this is going to help us decide WHICH tag is currently in play, when we go to implement reverse-mode and need to distinguish tape from differential... more on that in #226 .
littleredcomputer
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
*active-tags*stack that allows us to save work in the case of a nested derivative.*active-tags*is a stack containing the tags of all nested calls; in #226 , this is going to save us trouble when deciding whether aTapeCellshould wrap aDifferentialor vice versa if both show up in a computation.