Expand literal function descriptor language [in progress] 10000 #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09afe6a to
6db7a5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 83.98% 83.61% -0.38%
==========================================
Files 97 97
Lines 12872 12941 +69
Branches 674 675 +1
==========================================
+ Hits 10811 10821 +10
- Misses 1387 1445 +58
- Partials 674 675 +1
Continue to review full report at Codecov.
|
Closed
afa6dd7 to
c33ef42
Compare
|
Moved to Emmy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full port of
litfun.scmand the function descriptor language from scmutils.== Literal Function Descriptor Language
We support some of the possible literal function types; these are type signatures like
(-> (UP Real Real) Real). Butlitfun.scmhas support for a richer language.litfun.scmand port the full scope of function descriptor language, including lots of helper functions likeLagrangian. There are also many examples here that would make great tests. This can live insicmutils.abstract.function.cljc(UP* Real)should work, with no explicit arity.([] '(-> (UP Real (UP* Real) (DOWN* Real)) Real))([] '(-> (UP Real (UP* Real) (UP* Real)) Real)). the current impl can't handle stars with no numbers.