This repository was archived by the owner on Jun 18, 2025. It is now read-only.
analyzer, performance improvement sketch [in progress] #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d1ba18 to
f25565a
Compare
f25565a to
6ad5eec
Compare
702f525 to
1df5d1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
- Coverage 83.80% 81.51% -2.29%
==========================================
Files 95 95
Lines 12052 12189 +137
Branches 620 751 +131
==========================================
- Hits 10100 9936 -164
- Misses 1332 1502 +170
- Partials 620 751 +131
Continue to review full report at Codecov.
|
sritchie
commented
May 1, 2021
| (defn numeric-zero? [x] | ||
| (p :v/numeric-zero? | ||
| (and (number? x) | ||
| (zero? x)))) |
There was a problem hiding this comment.
todo make scalar? fast too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big chunk of #341, split off from the rest.