8000 next sync committee branch calculated incorrectly · Issue #7441 · sigp/lighthouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

next sync committee branch calculated incorrectly #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benluelo opened this issue May 12, 2025 · 1 comment
Closed

next sync committee branch calculated incorrectly #7441

benluelo opened this issue May 12, 2025 · 1 comment
Labels
bug Something isn't working light-client

Comments

@benluelo
Copy link

lighthouse: https://ethereum-beacon-api.publicnode.com/eth/v1/beacon/light_client/updates?start_period=1420&count=6
lodestar: https://lodestar-mainnet.chainsafe.io/eth/v1/beacon/light_client/updates?start_period=1420&count=6

556c556
<         "0x504373599ac3b799767d44b05f3809f01b85057a24a4ea11b7f3c6a6a175837d",
---
>         "0x3c52adeac342b3ae75f8cccb0df305bd816c4ebe5dcc295edffa9824d4f3b60d",
609,610c609
<     },
<     "version": "deneb"
---
>     }
1166c1165
<         "0x3c52adeac342b3ae75f8cccb0df305bd816c4ebe5dcc295edffa9824d4f3b60d",
---
>         "0x02e2764784ce09de80c2bb7c82c708447302c444cf36844abb85ee3cb6b0cb6e",
1219,1220c1218
<     },
<     "version": "deneb"
---
>     }
1776c1774
<         "0x02e2764784ce09de80c2bb7c82c708447302c444cf36844abb85ee3cb6b0cb6e",
---
>         "0x396a997227554ba1bed4b784c1da37ae76b9f2278dbe3d2b2714a878041dbb73",
1831,1832c1829
<     },
<     "version": "electra"
---
>     }
2388c2385
<         "0x396a997227554ba1bed4b784c1da37ae76b9f2278dbe3d2b2714a878041dbb73",
---
>         "0x5bc70cbdee70d51698c6df292058adf901b07b8e7a2e96375413bb552f25f51e",
2443,2444c2440
<     },
<     "version": "electra"
---
>     }
3000c2996
<         "0x5bc70cbdee70d51698c6df292058adf901b07b8e7a2e96375413bb552f25f51e",
---
>         "0x00a6a63e163d072f7bfebc2293da83d797be448f4177112ded1cc85d9153b8ce",
3055,3056c3051
<     },
<     "version": "electra"
---
>     }
3612c3607
<         "0x00a6a63e163d072f7bfebc2293da83d797be448f4177112ded1cc85d9153b8ce",
---
>         "0xf3c0e9972a9cdac7253db71729b45a2750c376b9a0d78eadefa160fc0a430221",
3667,3668c3662
<     },
<     "version": "electra"
---
>     }

i think this is incorrect, current and next should be switched in the tuple:

lighthouse/beacon_node/beacon_chain/src/light_client_server_cache.rs

Lines 426 to 429 in e42406d

let (finality_branch, next_sync_committee_branch, current_sync_committee_branch) = (
state.compute_finalized_root_proof()?,
state.compute_current_sync_committee_proof()?,
state.compute_next_sync_committee_proof()?,

@michaelsproul michaelsproul added light-client bug Something isn't working labels May 12, 2025
@eserilev eserilev mentioned this issue May 12, 2025
Merged
mergify bot pushed a commit that referenced this issue May 13, 2025
@eserilev
Next sync committee branch bug (#7443)
807848b 
#7441


  Make sure we're correctly caching light client data
@eserilev
Copy link
Member

Thanks for the bug report!

This was closed via #7443

@michaelsproul michaelsproul mentioned this issue May 29, 2025
Closed
@ParthDesai ParthDesai mentioned this issue Jun 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working light-client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelsproul @eserilev @benluelo
0