8000 Add e2e sync tests for lookup and range sync to CI · Issue #7550 · sigp/lighthouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add e2e sync tests for lookup and range sync to CI #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jimmygchen opened this issue Jun 3, 2025 · 0 comments
Open

Add e2e sync tests for lookup and range sync to CI #7550

jimmygchen opened this issue Jun 3, 2025 · 0 comments
Assignees
@chong-he
Labels
syncing test improvement Improve tests

Comments

@jimmygchen
Copy link
Member

I made an attempt to add the following tests on to in #7530

  • genesis sync on a local devnet (covers current and next fork)
    • brief shutdown and restart (covers lookup sync)
    • longer shutdown and restart (covers range sync)

I tried using kurtosis-sync-tests and ran into a some issues with assertoor and I ended up removing the tests from the PR so we can move forward.

Given the simplicity of these tests, I think we could just have a simple bash script (similar to the checkpoint sync one in #7530) to do this (without having to debug assertoor):

  1. Start a network
  2. Immediately shutdown a node for some time
  3. Restart the node and poll its sync status until it's fully sync

The matrix I think we should cover:

lighthouse/.github/workflows/local-testnet.yml

Lines 221 to 224 in cfcc0d2

strategy:
matrix:
fork: [electra, fulu]
offline_secs: [ 120, 300]

The commit for the previous attempt is here
6c7e839
@jimmygchen jimmygchen mentioned this issue Jun 3, 2025
Merged
5 tasks
@chong-he chong-he mentioned this issue Jun 5, 2025
Open
mergify bot pushed a commit that referenced this issue Jun 5, 2025
740C @jimmygchen
Add e2e sync tests to CI (#7530)
9a49720 
This PR adds the following sync tests to CI workflow - triggered when a PR is labeled `syncing` - to ensure we have some e2e coverage on basic sync scenarios:
- [x] checkpoint sync to a live network (covers range and backfill sync for _current_ fork)
- [x] checkpoint sync to a running devnet (covers range and backfill sync for _next_ fork)

It seems to work fine running on github hosted runners - but if performance become an issue we could switch to using self hosted runners for sepolia sync test. (standard CPU runners have 4 CPU, 16 GB ram - i think it _should_ be enough on sepolia / devnet networks)

The following tests have been **removed** from this PR and moved to a separate issue *(#7550)
- [x] genesis sync on a local devnet (covers current and next fork)
- [x] brief shutdown and restart (covers lookup sync)
- [x] longer shutdown and restart (covers range sync)

I'm hoping to keep these e2e test maintenance effort to a minimum - hopefully longer term we could have some generic e2e tests that works for all clients and the maintenance effort can be spread across teams.

### Latest test run:
https://github.com/sigp/lighthouse/actions/runs/15411744248

### Results:
<img width="687" alt="image" src="https://github.com/user-attachments/assets/c7178291-7b39-4f3b-a339-d3715eb16081" />
<img width="693" alt="image" src="https://github.com/user-attachments/assets/a8fc3520-296c-4baf-ae1e-1e887e660a3c" />

#### logs are available as artifacts:
<img width="629" alt="image" src="https://github.com/user-attachments/assets/3c0e1cd7-9c94-4d0c-be62-5e45179ab8f3" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chong-he chong-he

Labels
syncing test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimmygchen @chong-he
0