8000 [Merged by Bors] - Add zinken testnet by paulhauner · Pull Request #1741 · sigp/lighthouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Merged by Bors] - Add zinken testnet #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add zinken testnet #1741

wants to merge 3 commits into from

Conversation

paulhauner
Copy link
Member
@paulhauner paulhauner commented Oct 7, 2020 •
edited
Loading

Issue Addressed

Proposed Changes

This extends @danielschonfeld's work in #1739 with:

  • Use an empty boot node list
  • Remove the genesis state

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review A0 labels Oct 7, 2020
@paulhauner paulhauner requested a review from pawanjay176 October 7, 2020 06:02
@paulhauner paulhauner mentioned this pull request Oct 7, 2020
Closed
pawanjay176
pawanjay176 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member
@pawanjay176 pawanjay176 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Created a zinken validator and made a deposit which worked fine.

My only concern is that the directory setup in 0.2.x is such that users using the import command to import from the launchpad have to use --validator-dir flag to get their validator into the right directory and cannot use --datadir since it has issues.

During the spadina launch, I noticed that many users ended up importing their keys to the wrong directory and had to manually move it around just before genesis.

So if we are releasing this as part of 0.2.x, it'd be better to have an accompanying announcement telling users to explicitly not use the --datadir flag for the import command.

@paulhauner paulhauner changed the base branch from master to v0.3.0-staging October 7, 2020 06:57
@paulhauner
Copy link
Member Author

Oh great point @pawanjay176. I've changed the base to v0.3.0-staging accordingly. I had to do a force-push to keep a clean history.

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2020
@paulhauner @danielschonfeld
Add zinken testnet (#1741)
a67fa5f 
## Issue Addressed

- Resolves #1722

## Proposed Changes

This extends @danielschonfeld's work in #1739 with:

- Use an empty boot node list
- Remove the genesis state

## Additional Info

NA


Co-authored-by: Daniel Schonfeld <daniel@schonfeld.org>
@bors
Copy link
bors bot commented Oct 7, 2020

Pull request successfully merged into v0.3.0-staging.

Build succeeded:

@bors bors bot changed the title Add zinken testnet [Merged by Bors] - Add zinken testnet Oct 7, 2020
@bors bors bot closed this Oct 7, 2020
@michaelsproul michaelsproul deleted the add-zinken branch October 7, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Zinken testnet config
3 participants
@paulhauner @pawanjay176 @danielschonfeld
0