Add a name to the Tokio task #7544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
approved these changes
Jun 3, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The
console-subscriberfeature was added in #7529. However, the names of the running tasks are blank:Proposed Changes
Set the task name using
tokio::task::Builder, which is availble when thetokio_unstableis enabled.Additional Info
As you can see in the screenshot, there are many tasks named as
libp2p. I think it would be more informative if those tasks were named after their Behaviour name instead of justlibp2p(e.g.,gossipsub). But that would require changes to rust-libp2p.