8000 Do not compute sync selection proofs for the sync duty at the current slot by dknopik · Pull Request #7551 · sigp/lighthouse · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not compute sync selection proofs for the sync duty at the current slot #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

dknopik
Copy link
Member
@dknopik dknopik commented Jun 3, 2025

As ag 8000 gregation has already been performed in the last third of the previous slot, we no longer need the selection proof for the duty at the current slot.

See also the discussion at #7016 (comment)

CC @michaelsproul

As aggregation has already been performed in the last third of the previous slot, we no longer need the selection proof for the duty at the current slot.
@dknopik
Copy link
Member Author
dknopik commented Jun 5, 2025

@chong-he
Opposed to my comment in linked PR, I decided to not also add 1 to pre_compute_slot as in prepare_for_aggregator_pre_compute we take the last_slot_of_period as upper bound. Adding 1 to that causes another off-by-one, as that slot would then belong to the next period.

@dknopik
Copy link
Member Author
dknopik commented Jun 5, 2025

I'll also try to add a test somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0