8000 e2e: select checkout ref based on event type. by wlynch · Pull Request #57 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

e2e: select checkout ref based on event type. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2022
Merged

e2e: select checkout ref based on event type. #57

merged 1 commit into from
Jun 2, 2022

Conversation

wlynch
Copy link
Member
@wlynch wlynch commented Jun 2, 2022 •
edited
Loading

Summary

This change adds logic to select the ref to checkout for events.

By default pull_request_target will use the base branch as the
target since it was originally intended for trusted workloads.
However, we need to use this to have access to the OIDC creds
for the e2e tests, so insert our own logic here.
This is effectively a ternary of the form ${{ <condition> <true> || <false> }}.
See https://docs.github.com/en/actions/learn-github-actions/expressions for more details.

Signed-off-by: Billy Lynch billy@chainguard.dev

Ticket Link

Release Note

NONE

@wlynch
e2e: select checkout ref based on event type.
3629b5f 
This change adds logic to select the ref to checkout for events.

By default pull_request_target will use the base branch as the
target since it was originally intended for trusted workloads.
However, we need to use this to have access to the OIDC creds
for the e2e tests, so insert our own logic here.
This is effectively a ternary of the form ${{ <condition> <true> || <false> }}.
See https://docs.github.com/en/actions/learn-github-actions/expressions for more details.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
@wlynch wlynch merged commit dfe59ec into sigstore:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wlynch @imjasonh
0