8000 Fix non-constant format string error by TomHennen · Pull Request #619 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix non-constant format string error #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

Fix non-constant format string error #619

merged 1 commit into from
Jan 19, 2025

Conversation

TomHennen
Copy link
Contributor

Summary

I'd like to have the unit-tests working before looking in to making feature changes. They currently fail with

# github.com/sigstore/gitsign/internal/fork/ietf-cms
# [github.com/sigstore/gitsign/internal/fork/ietf-cms]
internal/fork/ietf-cms/verify_test.go:230:12: non-constant format string in call to (*testing.common).Fatalf
FAIL    github.com/sigstore/gitsign/internal/fork/ietf-cms [build failed]

Fixes #618.

Release Note

NONE

Documentation

No

@TomHennen
Fix non-constant format string error
85477d5 
Signed-off-by: Tom Hennen <tomhennen@google.com>
@adityasaky adityasaky enabled auto-merge (squash) January 19, 2025 16:54
@adityasaky adityasaky merged commit f540890 into sigstore:main Jan 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasaky adityasaky adityasaky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests failing due to non-constant format string
2 participants
@TomHennen @adityasaky
0