Implement Credential Caching #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Jun 16, 2022
This introduces a socket based credential cache to allow caching of keys so that users do not need to go through the OIDC flow multiple times for batch operations (e.g. rebases). Credentials are keyed to git working directories so that different repos can cache different identities, and credentials are never directly stored to disk. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
reviewed
Jun 17, 2022
Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
previously approved these changes
Jun 22, 2022
znewman01
suggested changes
Jun 22, 2022
- Return CertSignerVerifier - Move static values to const - Use XDG_CACHE_DIR for user data directory. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
znewman01
approved these changes
Jun 23, 2022
imjasonh
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces a socket based credential cache to allow caching of keys
so that users do not need to go through the OIDC flow multiple times
for batch operations (e.g. rebases).
Credentials are keyed to git working directories so that different repos can
cache different identities, and credentials are never directly stored to disk.
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
Fixes #21
Release Note