Implement out of band OAuth. #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8a0edd to
d724ad9
Compare
This change adds out of ban OAuth support to allow users to generate OIDC tokens even if their current session does not support opening a brower. This works by reading/writting directly to the user's TTY, bypassing stdin/stdout that is being captured by Git. Co-authored-by: Ben Moss <benm@vmware.com> Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds out of band OAuth support to allow users to generate
OIDC tokens even if their current session does not support opening a
brower.
This works by reading/writing directly to the user's TTY, bypassing
stdin/stdout that is being captured by Git.
Big thanks to @benmoss for doing the initial leg-work here.
This change is dependent on sigstore/sigstore#514, so starting off as draft (even after this is submitted, we should double check the out-of-band flow - I was having trouble with the page redirects, though I was able to confirm that this works by nabbing the code from the devtools console).
Ticket Link
Fixes #20
Release Note