Use TTY output for errors. #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use user TTYs to output errors / panics directly to the user instead of them getting lost to stderr. Unfortunately if there is not a TTY available (this is common for CI runners - incl GitHub Actions by default_ then the GITSIGN_LOG variable is still required for debug output. Signed-off-by: Billy Lynch <billy@chainguard.dev>
imjasonh
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion
2EF3
to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This lets us use user TTYs to output errors / panics directly to the
user instead of them getting lost to stderr. Unfortunately if there is
not a TTY available (this is common for CI runners - incl GitHub Actions
by default) then the GITSIGN_LOG variable is still required for debug
output.
Signed-off-by: Billy Lynch billy@chainguard.dev
Ticket Link
n/a
Release Note