8000 Gitignore and verify consume by sallyom · Pull Request #109 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Gitignore and verify consume #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2022
Merged

Gitignore and verify consume #109

merged 3 commits into from
Aug 15, 2022

Conversation

sallyom
Copy link
Contributor
@sallyom sallyom commented Aug 11, 2022

Resolves #108

Summary

Refactor verify logic to be consumable by gitOps tools

Release Note

NONE

@sallyom sallyom force-pushed the gitignore-and-verify-consume branch 2 times, most recently from 4207510 to a01b737 Compare August 11, 2022 16:08
This was referenced Aug 11, 2022
Merged
Closed
imjasonh
imjasonh reviewed Aug 11, 2022
View reviewed changes
@sallyom sallyom force-pushed the gitignore-and-verify-consume branch 3 times, most recently from 2ed8a7f to 353b64e Compare August 11, 2022 17:34
wlynch
wlynch requested changes Aug 12, 2022
View reviewed changes
Copy link
Member
@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just some small doc things we should do before merging!

pkg/git/verify.go
)

type VerificationSummary struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the newly exposed types, let's add comments so there's docs in pkg.go.dev.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, feel free to offer some wording suggestions, thanks!

imjasonh
imjasonh previously approved these changes Aug 12, 2022
View reviewed changes
sallyom added 2 commits August 14, 2022 14:14
@sallyom
add vendor to .gitignore
bf06de9 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom
refactor to make verify consumable as library
af45e6e 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom sallyom force-pushed the gitignore-and-verify-consume branch from 353b64e to 2df2786 Compare August 14, 2022 18:43
@sallyom
comment exported verify types
8f2b7d6 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom sallyom force-pushed the gitignore-and-verify-consume branch from 2df2786 to 8f2b7d6 Compare August 14, 2022 18:44
@wlynch wlynch merged commit 1d4fc64 into sigstore:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@imjasonh imjasonh imjasonh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify logic refactor to make consumable by other tools
3 participants
@sallyom @imjasonh @wlynch
0