8000 config: Fork out to git binary for config data. by wlynch · Pull Request #149 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

config: Fork out to git binary for config data. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2022
Merged

config: Fork out to git binary for config data. #149

merged 1 commit into from
Sep 27, 2022

Conversation

wlynch
Copy link
Member
@wlynch wlynch commented Sep 26, 2022 •
edited
Loading

Summary

We do this as a hack since go-git has issues parsing global configs for custom fields and doesn't support deprecated subsection syntaxes.

Fixes #128
Fixes #142

Signed-off-by: Billy Lynch billy@chainguard.dev

Release Note

  • Adds support for global and system gitconfigs
  • Fixes bug where gitsign failed to parse configs with deprecated dot syntax.

Documentation

@wlynch wlynch requested review from imjasonh and cpanato September 26, 2022 17:15
@wlynch
config: Fork out to git binary for config data.
f3eae9c 
We do this as a hack since go-git has issues parsing global configs
for custom fields and doesn't support deprecated subsection syntaxes.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
@wlynch wlynch merged commit 2571804 into sigstore:main Sep 27, 2022
@wlynch wlynch mentioned this pull request Oct 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using dot syntax in global .gitconfig causes cryptic error Gitsign doesn't support git config --global options
2 participants
@wlynch @cpanato
0