8000 Refactor commands with Cobra. by wlynch · Pull Request #185 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor commands with Cobra. #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Refactor commands with Cobra. #185

merged 1 commit into from
Nov 9, 2022

Conversation

wlynch
Copy link
Member
@wlynch wlynch commented Nov 8, 2022

Summary

This PR rewrites the commands using Cobra so that it can be easier to add additional subcommands (i.e. gitsign cache, gitsign attest, etc.)

This change doesn't add any new functionality, though it does refactor a good chunk of the config, flags, status printing, and other global state to make it more easily consumable by packages.

Co-authored-by: Eddie Zaneski eddiezane@chainguard.dev

Release Note

Rewrites CLI subcommands using Cobra. This should be backwards compatible with the old CLI surface, but if it's not please let us know! 🙏

Documentation

N/A

@wlynch wlynch requested review from eddiezane and cpanato November 8, 2022 21:56
@wlynch wlynch force-pushed the cobra branch 2 times, most recently from 6c21a47 to baa1d63 Compare November 8, 2022 22:01
@wlynch @eddiezane
Refactor commands with Cobra.
36d1e10 
This PR rewrites the commands using Cobra so that it can be easier to
add additional subcommands (i.e. gitsign cache, gitsign attest, etc.)

This change doesn't add any new functionality, though it does refactor a
good chunk of the config, flags, status printing, and other global state
to make it more easily consumable by packages.

Co-authored-by: Eddie Zaneski <eddiezane@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
@wlynch wlynch merged commit 262c054 into sigstore:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wlynch @eddiezane
0