feat(core/time-picker|time-input): Rework ix-time-picker, add ix-time-input #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens/ix into feat/time-picker-time-input
🦋 Changeset detectedLatest commit: 5f4162f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danielleroux
requested changes
Apr 29, 2025
packages/core/src/components/datetime-picker/datetime-picker.tsx
Outdated
Show resolved
Hide resolved
Regarding this comment, everything was fixed except for the lateral movement behaviour, which will stay as it is (discussed with UX) |
nuke-ellington
requested changes
Jun 12, 2025
There was a problem hiding this comment.
The is no vertical maring between tiles anymore?
Simply moving laterally via arrow keys leads to unexpected behavior:
https://github.com/user-attachments/assets/9bf008e6-a165-467b-a5d9-504166b8de27
nuke-ellington
requested changes
Jun 18, 2025
nuke-ellington
previously approved these changes
Jun 18, 2025
|
nuke-ellington
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://agileworld.siemens.cloud/jira/browse/IX-1523
🆕 What is the new behavior?
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs)pnpm test)pnpm lint)pnpm build, changes pushed)