8000 Ix2377 radio by Raghavendra5577 路 Pull Request #1928 路 siemens/ix 路 GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ix2377 radio #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

Raghavendra5577
Copy link
@Raghavendra5577 Raghavendra5577 commented Jun 2, 2025

馃挕 What is the current behavior?

Radio's visible size is correct, but the active area needs to be larger to meet WCAG guidelines
When using a radio without label, the right space remains

GitHub Issue Number: # GitHub issue doesn't exit
jira issue number IX-2377

馃啎 What is the new behavior?

Active area of the radio without label is 24x24
visible size of radio is 20x20
Radio with label: the space between Checkbox and label is 8px/0.5rem

馃弫 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 馃 8000 Ξ Accessibility (a11y) features were implemented
  • 馃椇锔 Internationalization (i18n) - no hard coded strings
  • 馃摬 Responsiveness - components handle viewport changes and content overflow gracefully
  • 馃搫 Documentation was reviewed/updated siemens/ix-docs
  • 馃И Unit tests were added/updated and pass (pnpm test)
  • 馃摳 Visual regression tests were added/updated and pass (Guide)
  • 馃 Static code analysis passes (pnpm lint)
  • 馃彈锔 Successful compilation (pnpm build, changes pushed)

馃懆鈥嶐煉 Help & support

Copy link 8000
changeset-bot bot commented Jun 4, 2025

馃 Changeset detected

Latest commit: 40f788a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Raghavendra5577 Raghavendra5577 marked this pull request as ready for review June 6, 2025 08:58
Copy link
Collaborator
@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added a margin around the button but this area is still not interactive.
Component test is missing.

@Raghavendra5577
Copy link
Author

We added a margin around the button but this area is still not interactive. Component test is missing.

Hi Lukas,
We've added a margin around the button, but could you please let us know specifically which area is still not interactive? Once we have that clarity, we can implement the required changes accordingly.

Copy link

@Raghavendra5577
Copy link
Author

We added a margin around the button but this area is still not interactive. Component test is missing.

Hi Lukas,
"I've verified that the margin area around the button is responding to click events. Could you please specify which particular area is not interactive? A quick description or screenshot of the non-responsive region would help us implement the necessary fixes."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0