feat: lower message loop sleep interval #417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
previously approved these changes
Jun 23, 2025
ea10309 to
d7b12fc
Compare
d7b12fc to
68e7374
Compare
jakmeier
approved these changes
Jun 25, 2025
| @@ -45,7 +45,7 @@ impl PositAction { | |||
| pub enum PositInternalAction<S> { | |||
| StartProtocol(Vec<Participant>, Positor<S>), | |||
| Reply(PositAction), | |||
| Rejected, | |||
| Abort, | |||
There was a problem hiding this comment.
why is this renamed in this PR? 😅
There was a problem hiding this comment.
Because I promised to rename it in a different PR from this one: #421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this to see how much better our messaging is. In the future, sending messages out should be a bit smarter and more reactive by reaching the payload limit or timeout.
With this, I've noticed a slight performance increase in our
test_signature_basictest by about 5-10s