8000 feat: added corrosion to cmake of modules by PaulDelestrac · Pull Request #64 · silagokth/vesyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: added corrosion to cmake of modules #64

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2025
Merged

feat: added corrosion to cmake of modules #64

merged 4 commits into from
May 12, 2025

Conversation

PaulDelestrac
Copy link
Contributor
@PaulDelestrac PaulDelestrac commented May 12, 2025 •
edited
Loading

feat: added corrosion to cmake of modules

Description

Modules coded with Rust (i.e., [vs-component], [vs-manas], [vs-testcase], [vs-entry]) now use Corrosion for CMake build system.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested on my computer with latest drra-components master build.

Test Configuration:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@PaulDelestrac PaulDelestrac marked this pull request as ready for review May 12, 2025 13:23
@PaulDelestrac PaulDelestrac requested a review from herenvarno May 12, 2025 13:23
@PaulDelestrac PaulDelestrac self-assigned this May 12, 2025
@PaulDelestrac PaulDelestrac requested a review from Copilot May 12, 2025 13:23
Copilot

This comment was marked as outdated.

Sign in to view

@herenvarno herenvarno merged commit 49ad89b into master May 12, 2025
1 check passed
@herenvarno herenvarno deleted the feat-corrosion-cmake branch May 12, 2025 14:36
@PaulDelestrac PaulDelestrac added the changelog:feature Add to changelog: new feature or enhancement label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@herenvarno herenvarno herenvarno approved these changes

Assignees

@PaulDelestrac PaulDelestrac

Labels
changelog:feature Add to changelog: new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulDelestrac @herenvarno
0