DRAFT: Leaflet map using IFrame #9
Conversation
|
In the last few commit I did:
|
dist/client/index.html
Outdated
| @@ -7,5 +7,5 @@ | |||
| transition: opacity 0.25s 0.25s ease-in-out; | |||
| } | |||
| </style></head><body class="silex-loading"><div class="silex-loader silex-dialog">Loading | |||
| </div><link rel="stylesheet" type="text/css" href="css/admin.css?938790"><main class="silex-workspace"><div class="silex-main silex-dialog-hide silex-ui-full" id="gjs"></div></main><script src="js/main.js?938790"></script><script>silex.start() | |||
| </div><link rel="stylesheet" type="text/css" href="css/admin.css?216955"><main class="silex-workspace"><div class="silex-main silex-dialog-hide silex-ui-full" id="gjs"></div></main><script src="js/main.js?216955"></script><script>silex.start() | |||
There was a problem hiding this comment.
Did you change the favicon?
Why commit this?
There was a problem hiding this comment.
I didn't saw that I published this file. It modifies on his own every time I run my code so I didn't saw that the favicon had changed.
src/ts/client/grapesjs/index.ts
Outdated
| @@ -364,6 +364,144 @@ export async function initEditor(config: EditorConfig) { | |||
| try { | |||
| /* @ts-ignore */ | |||
| editor = grapesjs.init(config) | |||
|
|
|||
| // Remove default map block and component | |||
There was a problem hiding this comment.
Everything bellow should be in a grapesjs plugin in a separate file
There was a problem hiding this comment.
It will be added in my next commit
src/ts/client/grapesjs/index.ts
Outdated
| console.warn('Localisation not found') | ||
| } | ||
| } catch (error) { | ||
| console.error('Erreur de géocodage:', error) |
There was a problem hiding this comment.
On parle français alors finalement ?
There was a problem hiding this comment.
Fixed in the next commit, sorry didn't saw.
src/ts/client/grapesjs/index.ts
Outdated
| }, | ||
| view: { | ||
| onRender({ el }) { | ||
| el.style.border = 'none' |
There was a problem hiding this comment.
Why here and not with the rest of the styles (width, height)
There was a problem hiding this comment.
I chose to keep border: none in view.onRender because I wanted to ensure it remains fixed and is not overridden, as it prevents the default browser border on iframes. Width and height are placed in defaults.style to allow users to modify them with the StyleManager. But I can still move it if you want
Hello I update the feature again.
I did add and change a lot of things:
Requesting feedback on the handleMessage implementation, guidance on fixing the persistence issue with map coordinates.