find_symbol_nodes signature is incorrect #19

simonw · 2023-06-19T17:00:04Z

symbex -s find_symbol_nodes

# File: symbex/lib.py Line: 8
def find_symbol_nodes(code: str, symbols)

But it should be:

symbex/symbex/lib.py

Lines 8 to 10 in 46f8a6d

    
           def find_symbol_nodes( 
        
               code: str, symbols: Iterable[str] 
        
           ) -> List[Tuple[AST, Optional[str]]]:

simonw · 2023-06-19T17:07:48Z

I set ChatGPT Code Interpreter to work on this and it found a solution!

https://chat.openai.com/share/b9873d04-5978-489f-8c6b-4b948db7724d

It wrote this code (after a few iterations):

def get_annotation_str(annotation):
    """
    Helper function to return the correct string representation of a type annotation.

    Args:
        annotation (ast.expr): The AST node representing the type annotation.

    Returns:
        str: The string representation of the type annotation.
    """
    if annotation is None:
        return ""
    elif isinstance(annotation, ast.Name):
        return annotation.id
    elif isinstance(annotation, ast.Subscript):
        value = get_annotation_str(annotation.value)
        slice = get_annotation_str(annotation.slice)
        return f"{value}[{slice}]"
    elif isinstance(annotation, ast.Index):
        return get_annotation_str(annotation.value)
    elif isinstance(annotation, ast.Tuple):
        elements = ", ".join(get_annotation_str(e) for e in annotation.elts)
        return f"({elements})"
    else:
        return "?"

simonw · 2023-06-19T17:18:38Z

ChatGPT also suggested https://pypi.org/project/astor/ - if I wasn't trying to avoid extra dependencies that would be a really good option.

'Refs #14, #15, #16, #18, #19, #20

simonw added the bug Something isn't working label Jun 19, 2023

simonw closed this as completed in 82af911 Jun 19, 2023

simonw added a commit that referenced this issue Jun 19, 2023

Release 0.4

21c5deb

'Refs #14, #15, #16, #18, #19, #20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

find_symbol_nodes signature is incorrect #19

find_symbol_nodes signature is incorrect #19

Uh oh!

Uh oh!

Uh oh!

find_symbol_nodes signature is incorrect #19

find_symbol_nodes signature is incorrect #19

Comments

Uh oh!

Uh oh!