IsLiteral: Adding strict options and Fixing unpredictable behaviors…
#1153
Conversation
… of `IsStringLiteral` returning boolean for unions and `IsNumericLiteral` returning false for numeric unions - Matching `IsStringLiteral` behavior to the other is*Literals when dealing with unions of different types return boolean, now return false. - Fixing `IsNumericLiteral` return false for numeric union like (1 | 1n), now return true. - Adding `strict` option to control the behavior of `IsStringLiteral` against infinite signature types.
|
@som-sm I think this is a great way to solve the problem we encounter in |
|
@benzaria Please keep the PRs focused on a single change. In this case, just add the Keeping changes atomic makes it much easier to review and provide feedback. Hope that makes sense! |
|
@som-sm I want to point out that the issue u mentioned in the review for the boolean behavior getting removed from My thought on this is keeping the |
Ideally, all the logic should remain in export type IsStringLiteral<S, Options extends IsStringLiteralOptions = {}> =
ApplyDefaultOptions<IsStringLiteralOptions, DefaultIsStringLiteralOptions, Options> extends infer ResolvedOptions extends Required<IsStringLiteralOptions>
? IfNotAnyOrNever<S,
_IsStringLiteral<CollapseLiterals<S extends TagContainer<any> ? UnwrapTagged<S> : S>, ResolvedOptions>,
false, false>
: never;
type _IsStringLiteral<S, Options extends Required<IsStringLiteralOptions>> =
// If `T` is an infinite string type (e.g., `on${string}`), `Record<T, never>` produces an index signature,
// and since `{}` extends index signatures, the result becomes `false`.
S extends string
? Options['strict'] extends false
? LiteralChecks<S, string>
: {} extends Record<S, never>
? false
: true
: false;And, this would ensure you get |
|
@som-sm i did ur suggestion. and also later on we can modify |
5b79acc to
663365c
Compare
There was a problem hiding this comment.
@benzaria Please address this #1153 (comment), this PR still seems to have changes that are not related to adding strict option to IsLiteral and IsStringLiteral.
|
This PRs will be ready to review after Merge of |
@som-sm Are u referring to the changes on |
… of
IsNumericLiteralreturning false for numeric unionsstrictoption to control the behavior ofIsStringLiteralagainst infinite signature types.IsNumericLiteralreturn false for numeric union like (1 | 1n), now return true.Fixes #1145