8000 Stop preserving ownership, stop performing chmod after `copyFileSync` by stroncium · Pull Request #39 · sindresorhus/copy-file · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop preserving ownership, stop performing chmod after copyFileSync #39

New issue

Have a question about this project? 8000 Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2020
Merged

Stop preserving ownership, stop performing chmod after copyFileSync #39

merged 3 commits into from
Mar 5, 2020

Conversation

stroncium
Copy link
@stroncium stroncium commented Feb 27, 2020 •
edited by sindresorhus
Loading
  • Stop preserving ownership
  • Stop performing chmod after copyFileSync
  • Remove related dead code and tests

Fixes #22.

🦄

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Owner

We can explicitly document that only mode is preserved, not ownership.

@sindresorhus sindresorhus changed the title Stop preserving ownership, stop performing chmod after copyFileSync, solves #22 Stop preserving ownership, stop performing chmod after copyFileSync Mar 3, 2020
Yanis Benson and others added 2 commits March 4, 2020 01:59
@sindresorhus sindresorhus merged commit 4e536d5 into sindresorhus:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditionally stop doing the chmod stuff
2 participants
@stroncium @sindresorhus
0