8000 Add options to `escape-case` and `number-literal-case` by otomad · Pull Request #2559 · sindresorhus/eslint-plugin-unicorn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add options to escape-case and number-literal-case #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 8, 2025
Merged

Add options to escape-case and number-literal-case #2559

merged 17 commits into from
Mar 8, 2025

Conversation

otomad
Copy link
Contributor
@otomad otomad commented Feb 17, 2025 •
edited
Loading

Close #2078 .

  • escape-case add an option to accept lowercase escape value.
  • number-literal-case add options to accept lowercase hexadecimal value, uppercase radix identifier and exponential notation.

@sindresorhus
Copy link
Owner

I prefer dropping the radixIdentifier and exponentialNotation option. Every added option adds an additional maintenance burden and I don't think we should add things just because. I doubt anyone will actually use them, and every user has to read, consider, and understand each option.

@otomad
Copy link
Contributor Author
otomad commented Mar 3, 2025

I prefer dropping the radixIdentifier and exponentialNotation option. Every added option adds an additional maintenance burden and I don't think we should add things just because. I doubt anyone will actually use them, and every user has to read, consider, and understand each option.

Should I also drop the "ignore" option? Which can convert 0XAbCd to 0xAbCd. If it's for readable code, I think it should also be dropped.

@sindresorhus
Copy link
Owner

Yes

@otomad
Copy link
Contributor Author
otomad commented Mar 3, 2025

Done.

@sindresorhus
Copy link
Owner

A lint issue: https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/13649042331/job/38153296589

@sindresorhus sindresorhus requested a review from fisker March 8, 2025 11:54
@fisker fisker merged commit 0f6048c into sindresorhus:main Mar 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: Require escape sequences to use lowercase values
3 participants
@otomad @sindresorhus @fisker
0