Upgrade signal-exit to v4
#570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 6, 2023
| @@ -177,17 +177,17 @@ test('spawnAndKill cleanup detached SIGKILL', spawnAndKill, ['SIGKILL', true, tr | |||
| // See #128 | |||
| test('removes exit handler on exit', async t => { | |||
| // @todo this relies on `signal-exit` internals | |||
| const emitter = process.__signal_exit_emitter__; | |||
| const emitter = globalThis[Symbol.for('signal-exit emitter')]; | |||
There was a problem hiding this comment.
signal-exit v4 changes how it exposes its global event listener.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
signal-exitto a new major version.Note: we should still wait until we upgrade
get-streambefore making a major release. That upgrade is currently being blocked by an issue inget-streamI have opened here: sindresorhus/get-stream#56