fix: official IANA MIME type for Apache Parquet files #748
Conversation
|
Hi @JoeCap08055, thanks for correcting the MIME type. I failed to find any trace of documentation mentioning |
@Borewit I saw it in the official IANA descriptor here
Also, see this GH issue that calls out "PARE" as being a magic number for Parquet files with encryption: |
|
Side note: the Parquet docs only specifically refer to "PARE" being used for an encrypted file footer, not the header, so technically it wouldn't apply to file type determination, but it also can't hurt--and as it's a registered IANA magic number, it can't be misinterpreted as some other type. @Borewit Your call on whether to leave the check in the code for "PARE" or not. |
|
Thanks for providing the background @JoeCap08055 , makes total sense to include that one indeed. |
|
Looks good to me, but this is a breaking change and must wait for the next major version. |
@sindresorhus that's unfortunate, but makes sense--is there a rough estimate of when that's expected? |
|
@sindresorhus , we now have a number PR's with some minor API changes, I think this is a good moment to start merging those and start to work towards a major release. |
The MIME type 'application/x-parquet' is old/deprecated/unofficial. The official MIME type is:
application/vnd.apache.parquet.Also added a missing magic number for this type.
https://www.iana.org/assignments/media-types/application/vnd.apache.parquet
If you're adding support for a new file type, please follow the below steps:
typesarray insupported.js.core.jsfile.