Fix optipng-linter.sh to handle multiple pngs #129

siebert · 2018-10-17T12:47:57Z

Also clean up the script and make it pass shellcheck.

siebert · 2018-10-17T12:58:52Z

I have no idea why Travis CI complains about formatting in python files when only a shell file is changed by this commit. Seems to me an error in the CI configuration.

sk- · 2018-10-17T13:24:26Z

@siebert I don't see how this PR is handling multiple images.
Note though that instead of using that simplistic script a much better alternative would be to use https://github.com/sk-/optimage.

Thanks for pointing the problem with the Python formatting, the reason is because I didn't pin the yapf version in the requirements.

siebert · 2018-10-17T13:32:55Z

The actual fix is this line:

OUTFILE="$(mktemp)"

Using a fixed tempfile name didn't work for me for patches which contains multiple pngs. Apparently the script is run in parallel, so the same tempfile is rewritten/removed by other instances when tried to read by the current instance which then fails.

Also clean up the script and make it pass shellcheck.

Fix optipng-linter.sh to handle multiple pngs

a92fa64

Also clean up the script and make it pass shellcheck.

siebert force-pushed the master-optipng branch from 31db88e to a92fa64 Compare October 17, 2018 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix optipng-linter.sh to handle multiple pngs #129

Fix optipng-linter.sh to handle multiple pngs #129

Fix optipng-linter.sh to handle multiple pngs #129

Are you sure you want to change the base?

Fix optipng-linter.sh to handle multiple pngs #129

Conversation