This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: extend api and conn handlers #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 73.19% 72.68% -0.51%
==========================================
Files 104 105 +1
Lines 5599 5635 +36
==========================================
- Hits 4098 4096 -2
- Misses 1222 1260 +38
Partials 279 279 ☔ View full report in Codecov by Sentry. |
aljo242
reviewed
Jan 25, 2024
Comment on lines
144
to
149
| // SetConnection is used to set the connection to the data provider. | ||
| func (h *WebSocketConnHandlerImpl) SetConnection(conn *websocket.Conn) { | ||
| h.Lock() | ||
| defer h.Unlock() | ||
|
|
||
| h.conn = conn |
There was a problem hiding this comment.
Since we currently only allow for one connection, should we error or return if the connection is already set?
aljo242
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.