This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: bitfinex ws #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 72.50% 72.09% -0.42%
==========================================
Files 108 111 +3
Lines 5802 5978 +176
==========================================
+ Hits 4207 4310 +103
- Misses 1307 1369 +62
- Partials 288 299 +11 ☔ View full report in Codecov by Sentry. |
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
added 2 commits
January 26, 2024 11:42
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
davidterpay
reviewed
Jan 26, 2024
Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
davidterpay
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BLO-734
Use channel map to track state. BitFinex stream messages are not
jsonencoded, so a lot of interface conversion needs to be done.See bitfinex implementation for similar logic.