8000 refactor: Factor vote-weighted median logic out of preblock and into its own pkg [BLO-814] by nivasan1 · Pull Request #75 · skip-mev/connect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

refactor: Factor vote-weighted median logic out of preblock and into its own pkg [BLO-814] #75

Merged
merged 2 commits into from
Feb 2, 2024
Merged

refactor: Factor vote-weighted median logic out of preblock and into its own pkg [BLO-814] #75

merged 2 commits into from
Feb 2, 2024

Conversation

nivasan1
Copy link
Contributor
@nivasan1 nivasan1 commented Feb 1, 2024

In This PR

  • I factor out the vote-weighted median calculation from preblock into it's own package

@codecov Codecov
Copy link
codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (bd3b01e) 74.85% compared to head (0460bae) 74.73%.
Report is 1 commits behind head on nv/factor-ve-aggregation.

❗ Current head 0460bae differs from pull request most recent head dc5beee. Consider uploading reports for the commit dc5beee to get more accurate results

Files Patch % Lines
abci/strategies/aggregator/vote_aggregator.go 62.50% 23 Missing and 7 partials ⚠️
pkg/math/voteweighted/voteweighted.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           nv/factor-ve-aggregation      #75      +/-   ##
============================================================
- Coverage                     74.85%   74.73%   -0.13%     
============================================================
  Files                           131      131              
  Lines                          5297     5307      +10     
============================================================
+ Hits                           3965     3966       +1     
- Misses                         1001     1009       +8     
- Partials                        331      332       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aljo242
aljo242 approved these changes Feb 1, 2024
View reviewed changes
pkg/math/vote-weighted/math.go Outdated
@@ -1,4 +1,4 @@
package math
package voteweighted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like we have a discrepancy between the package name voteweighted and the dir name vote-weighted.

I say we just use voteweighted.

Also the file math.go should probably be voteweighted.go

@nivasan1 nivasan1 force-pushed the nv/factor-ve-aggregation branch from 837079b to 8a2f8ac Compare February 2, 2024 18:05
@nivasan1 nivasan1 force-pushed the nv/factor-vote-weighted-pkg branch from b94c6e0 to 0460bae Compare February 2, 2024 18:06
@nivasan1 nivasan1 force-pushed the nv/factor-vote-weighted-pkg branch from 0460bae to dc5beee Compare February 2, 2024 19:27
@nivasan1 nivasan1 changed the base branch from nv/factor-ve-aggregation to main February 2, 2024 19:35
@nivasan1 nivasan1 merged commit 9fa036a into main Feb 2, 2024
@zrbecker zrbecker deleted the nv/factor-vote-weighted-pkg branch November 5, 2024 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidterpay davidterpay davidterpay approved these changes

@aljo242 aljo242 aljo242 approved these changes

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nivasan1 @davidterpay @aljo242
0