-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 56.99% 56.99%
=======================================
Files 210 210
Lines 11718 11718
=======================================
Hits 6679 6679
Misses 4431 4431
Partials 608 608 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L
docs/developers/connect-sdk.mdx
Outdated
use connect_sdk::bindings::query::ConnectQuery; | ||
use connect_sdk::bindings::querier::ConnectQuerier; | ||
use connect_sdk::bindings::marketmap::types::CurrencyPair; | ||
use cosmwasm_std::{entry_point, Binary, Deps, DepsMut, Empty, Env, MessageInfo, Response, StdResult, to_json_binary, Int128, StdError}; |
There was a problem hiding this comment.
10000Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused imports: Binary
, DepsMut
, Empty
, MessageInfo
, Response
, entry_point
, and to_json_binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed em 🤙🏻
} | ||
|
||
// Check price validity | ||
let price_response = connect_querier.get_oracle_price(base, quote)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error[E0061]: this method takes 1 argument but 2 arguments were supplied
--> contracts/x-oracle-passthrough/src/contract.rs:22:42
|
22 | let price_response = connect_querier.get_oracle_price(base, quote)?;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, im using v0.1.0 for the example, likely an error from v0.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill add that im using that version to the doc
yerrrr
closes: CON-1770