This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: dynamic metrics #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 56.55% 57.17% +0.61%
==========================================
Files 212 213 +1
Lines 11846 11900 +54
==========================================
+ Hits 6700 6804 +104
+ Misses 4537 4486 -51
- Partials 609 610 +1 ☔ View full report in Codecov by Sentry. |
zrbecker
approved these changes
Oct 8, 2024
…ry-if-node-is-not-started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new metrics impl,
dynamic metricswhich is a thin wrapper for a Metrics impl. If the metrics impl is a noop impl, and we have telemetry enabled, dynamic metrics will kick off a routine that tries to contact the node. if the node is contacted successfully, we attempt to switch our metrics impl to OracleMetricsImpl.