This repository was archived by the owner on Mar 24, 2025. It is now read-only.
fix: ics provider version #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 57.17% 57.15% -0.02%
==========================================
Files 213 213
Lines 11900 11900
==========================================
- Hits 6804 6802 -2
- Misses 4486 4488 +2
Partials 610 610 ☔ View full report in Codecov by Sentry. |
zrbecker
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I bumped our ICS version to v6, I forgot to bump this constant string which is the image version that is fetched.
Now using v6.0.0 which is a version family needed and the latest supported by strangeloves image registry
After merge I will make a
v2.1.1release to unblock ICS v6 team who may be using our e2e test suite