This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Market Configurations Proto #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 74.95% 74.98% +0.02%
==========================================
Files 135 135
Lines 5531 5537 +6
==========================================
+ Hits 4146 4152 +6
Misses 1040 1040
Partials 345 345 ☔ View full report in Codecov by Sentry. |
davidterpay
commented
Feb 8, 2024
Comment on lines
12
to
13
| // ID is a unique sequentially-generated value for the ticker. | ||
| uint64 id = 1; |
There was a problem hiding this comment.
this should have a 1:1 mapping with what is stored in the x/oracle module.
There was a problem hiding this comment.
Do we actually need this? Since the kvstore access in x/oracle is BASE/QUOTE doesnt using that already give use 1:1 mapping?
Just run make proto-all before merging |
davidterpay
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes BLO-876