This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: Use sdk Context with timeout for Price query #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Eric-Warehime
requested review from
davidterpay,
nivasan1 and
aljo242
as code owners
February 9, 2024 00:31
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 74.95% 75.02% +0.07%
==========================================
Files 135 135
Lines 5537 5537
==========================================
+ Hits 4150 4154 +4
+ Misses 1042 1038 -4
Partials 345 345 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom oracle clients might require an sdk.Context. Passing in the sdk.Context is fully compatible w/ the expected context.Context interface and also allows us to convert the type to an sdk.Context if we need to.