8000 feat: types basic validation by davidterpay · Pull Request #107 · skip-mev/connect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

feat: types basic validation #107

Merged
merged 20 commits into from
Feb 9, 2024
Merged

feat: types basic validation #107

merged 20 commits into from
Feb 9, 2024

Conversation

davidterpay
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link
codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (9eb285d) 74.98% compared to head (5bc2337) 74.87%.

Files Patch % Lines
x/marketmap/types/path.go 79.20% 18 Missing and 3 partials ⚠️
x/marketmap/types/ticker.go 55.55% 16 Missing ⚠️
x/marketmap/types/market.go 54.83% 9 Missing and 5 partials ⚠️
x/marketmap/types/genesis.go 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           feat/marketmap     #107      +/-   ##
==================================================
- Coverage           74.98%   74.87%   -0.12%     
==================================================
  Files                 135      140       +5     
  Lines                5537     5735     +198     
==================================================
+ Hits                 4152     4294     +142     
- Misses               1040     1088      +48     
- Partials              345      353       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

davidterpay
davidterpay commented Feb 9, 2024
View reviewed changes
x/marketmap/types/path.go
// receives a price for BTC/USDT and USDT/USD, the order must be BTC/USDT -> USDT/USD.
// Alternatively, if the oracle receives a price for BTC/USDT and USD/USDT, the order
// must be BTC/USDT -> USD/USDT (inverted == true).
func (p *Path) ValidateBasic() error {
Copy link
Contributor A 8000 uthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more or less copy pasted from the other config logic.

@davidterpay davidterpay marked this pull request as ready for review February 9, 2024 15:57
aljo242
aljo242 reviewed Feb 9, 2024
View reviewed changes
@aljo242 aljo242 merged commit bd2fca4 into feat/marketmap Feb 9, 2024
@aljo242 aljo242 deleted the terpay/proto-validation branch February 9, 2024 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@nivasan1 nivasan1 Awaiting requested review from nivasan1

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidterpay @aljo242
0