8000 feat: manually stopping providers by davidterpay · Pull Request #118 · skip-mev/connect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

feat: manually stopping providers #118

Merged
merged 13 commits into from
Feb 13, 2024
Merged

feat: manually stopping providers #118

merged 13 commits into from
Feb 13, 2024

Conversation

davidterpay
Copy link
Contributor
@davidterpay davidterpay commented Feb 12, 2024 •
edited
Loading

closes BLO-902

@codecov Codecov
Copy link
codecov bot commented Feb 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@cd0e34b). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage        ?   75.29%           
=======================================
  Files           ?      137           
  Lines           ?     5623           
  Branches        ?        0           
=======================================
  Hits            ?     4234           
  Misses          ?     1043           
  Partials        ?      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay marked this pull request as ready for review February 12, 2024 23:29
aljo242
aljo242 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor
@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this co 8000 mment to others. Learn more.

lgtm with small idea

providers/base/provider.go
p.logger.Debug("stopping provider")
cancel()
retErr = <-errCh
break MainLoop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using break MainLoop here and in the other cases makes sense. Maybe we add continue MainLoop for the restart case?

this might be overkill

@davidterpay davidterpay changed the base branch from terpay/config-updater to main February 13, 2024 15:51
@davidterpay davidterpay merged commit 272c7f9 into main Feb 13, 2024
@zrbecker zrbecker deleted the terpay/stop-provider branch November 5, 2024 21:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aljo242 aljo242 aljo242 approved these changes

@nivasan1 nivasan1 Awaiting requested review from nivasan1

@Eric-Warehime Eric-Warehime Awaiting requested review from Eric-Warehime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidterpay @aljo242
0