This repository was archived by the owner on Mar 24, 2025. It is now read-only.
refactor: market map config refactor #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/marketmap #145 +/- ##
==================================================
- Coverage 59.68% 59.42% -0.26%
==================================================
Files 226 225 -1
Lines 8914 8830 -84
==================================================
- Hits 5320 5247 -73
+ Misses 2992 2982 -10
+ Partials 602 601 -1 ☔ View full report in Codecov by Sentry. |
davidterpay
reviewed
Feb 20, 2024
Comment on lines
34
to
45
|
|
||
| // Paths is the list of convertable markets that will be used to convert the | ||
| // prices of a set of tickers to a common ticker. | ||
| repeated Path paths = 5 [ (gogoproto.nullable) = false ]; | ||
|
|
||
| // Providers is the list of provider configurations for the given ticker. | ||
| repeated ProviderConfig providers = 6 [ (gogoproto.nullable) = false ]; | ||
|
|
||
| // MetadataJSON is a string of JSON that encodes any extra configuration | ||
| // for the given ticker. | ||
| string metadata_JSON = 15; | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Paths is the list of convertable markets that will be used to convert the | |
| // prices of a set of tickers to a common ticker. | |
| repeated Path paths = 5 [ (gogoproto.nullable) = false ]; | |
| // Providers is the list of provider configurations for the given ticker. | |
| repeated ProviderConfig providers = 6 [ (gogoproto.nullable) = false ]; | |
| // MetadataJSON is a string of JSON that encodes any extra configuration | |
| // for the given ticker. | |
| string metadata_JSON = 15; | |
| } | |
| // Paths is the list of convertable markets that will be used to convert the | |
| // prices of a set of tickers to a common ticker. | |
| repeated Path paths = 5 [ (gogoproto.nullable) = false ]; | |
| // Providers is the list of provider configurations for the given ticker. | |
| repeated ProviderConfig providers = 6 [ (gogoproto.nullable) = false ]; | |
| // MetadataJSON is a string of JSON that encodes any extra configuration | |
| // for the given ticker. | |
| string metadata_JSON = 7; | |
| } |
davidterpay
reviewed
Feb 20, 2024
Comment on lines
+17
to
+18
| // MaxPathLength is the maximum length of a path for a ticker conversion. | ||
| MaxPathLength = 2 |
There was a problem hiding this comment.
Why are we setting this at 2? I think 3 should be allowed
davidterpay
approved these changes
Feb 20, 2024
Eric-Warehime
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.