This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat: more sidecar metrics #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
davidterpay
reviewed
Jan 24, 2024
Comment on lines
+33
to
39
|
|
||
| // UpdatePrice price updates the price for the given pairID for the provider. | ||
| UpdatePrice(name, handlerType, pairID string, price float64) | ||
|
|
||
| // UpdateAggregatePrice rice updates the aggregated price for the given pairID. | ||
| UpdateAggregatePrice(pairID string, price float64) | ||
| } |
There was a problem hiding this comment.
I would probably add one more metric here something like
AddPriceIncluded(name, handlertype, pairID, true/false)
this way we can track what price feeds are too stale in terms of how often they end up being consumed by the aggregator.
There was a problem hiding this comment.
won't the timestamps of the updates being pushed to the db show us how stale they are?
davidterpay
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BLO-803
GetResultinterface (alias forfmt.Stringer) as a type restriction for our generic code