This repository was archived by the owner on Mar 24, 2025. It is now read-only.
feat(providers/api): multi-solana-client [BLO-1067] #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 62.46% 62.46%
=======================================
Files 220 222 +2
Lines 9734 9798 +64
=======================================
+ Hits 6080 6120 +40
- Misses 3102 3122 +20
- Partials 552 556 +4 ☔ View full report in Codecov by Sentry. |
369e64c to
6f60353
Compare
eab5cba to
3407a12
Compare
aljo242
reviewed
Apr 4, 2024
5739225 to
f279e4c
Compare
76d4f58 to
ff34ce4
Compare
nivasan1
commented
Apr 5, 2024
aljo242
approved these changes
Apr 5, 2024
cmd/slinky-config/main.go
Outdated
Comment on lines
378
to
384
| nodes := strings.Split(solanaNodeURLs, ",") | ||
|
|
||
| for _, node := range nodes { | ||
| cfg.Endpoints = append(cfg.Endpoints, config.Endpoint{ | ||
| URL: node, | ||
| }) | ||
| } |
There was a problem hiding this comment.
The solanaNodeURLs flag should just be a StringSliceVarP. It eliminates all of this code.
Comment on lines
49
to
81
| // Create a channel to receive the responses from the underlying clients | ||
| responsesCh := make(chan *rpc.GetMultipleAccountsResult, len(c.clients)) | ||
|
|
||
| // spawn a goroutine for each client to fetch the accounts | ||
| var wg sync.WaitGroup | ||
| wg.Add(len(c.clients)) | ||
|
|
||
| for i := range c.clients { | ||
| go func(client SolanaJSONRPCClient) { | ||
| defer wg.Done() | ||
| resp, err := client.GetMultipleAccountsWithOpts(ctx, accounts, opts) | ||
| if err != nil { | ||
| c.logger.Error("failed to fetch accounts", zap.Error(err)) | ||
| return | ||
| } | ||
| responsesCh <- resp | ||
| }(c.clients[i]) | ||
| } | ||
|
|
||
| // close the channel once all responses are received, or the context is cancelled | ||
| go func() { | ||
| select { | ||
| case <-ctx.Done(): | ||
| c.logger.Error("context cancelled") | ||
| case <-channelForWaitGroup(&wg): | ||
| } | ||
| close(responsesCh) | ||
| }() | ||
|
|
||
| responses := make([]*rpc.GetMultipleAccountsResult, 0, len(c.clients)) | ||
| for resp := range responsesCh { | ||
| responses = append(responses, resp) | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Create a channel to receive the responses from the underlying clients | |
| responsesCh := make(chan *rpc.GetMultipleAccountsResult, len(c.clients)) | |
| // spawn a goroutine for each client to fetch the accounts | |
| var wg sync.WaitGroup | |
| wg.Add(len(c.clients)) | |
| for i := range c.clients { | |
| go func(client SolanaJSONRPCClient) { | |
| defer wg.Done() | |
| resp, err := client.GetMultipleAccountsWithOpts(ctx, accounts, opts) | |
| if err != nil { | |
| c.logger.Error("failed to fetch accounts", zap.Error(err)) | |
| return | |
| } | |
| responsesCh <- resp | |
| }(c.clients[i]) | |
| } | |
| // close the channel once all responses are received, or the context is cancelled | |
| go func() { | |
| select { | |
| case <-ctx.Done(): | |
| c.logger.Error("context cancelled") | |
| case <-channelForWaitGroup(&wg): | |
| } | |
| close(responsesCh) | |
| }() | |
| responses := make([]*rpc.GetMultipleAccountsResult, 0, len(c.clients)) | |
| for resp := range responsesCh { | |
| responses = append(responses, resp) | |
| } | |
| responses := make([]*rpc.GetMultipleAccountsResult, 0, len(c.clients)) | |
| // spawn a goroutine for each client to fetch the accounts | |
| var wg sync.WaitGroup | |
| wg.Add(len(c.clients)) | |
| for i := range c.clients { | |
| go func(client SolanaJSONRPCClient) { | |
| defer wg.Done() | |
| resp, err := client.GetMultipleAccountsWithOpts(ctx, accounts, opts) | |
| if err != nil { | |
| c.logger.Error("failed to fetch accounts", zap.Error(err)) | |
| return | |
| } | |
| responses[i] = resp | |
| }(c.clients[i]) | |
| } | |
| wg.Wait() |
There was a problem hiding this comment.
I'm struggling to see why we need anything more than parallelized fetches here. Anything that errors out will properly have no results, and we block on all the responses returning no matter what.
There was a problem hiding this comment.
This logic defers to context closure over all clients finishing their outbound requests. Agreed that the behavior is the same if the underlying client defers to context closure
Eric-Warehime
approved these changes
Apr 5, 2024
aljo242
approved these changes
Apr 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This PR
Endpointsfield to the config, where we can place node-urls / authentication, etcMultiClientto raydium to permit querying across multiple separated node-providers + aggregating repsonses from among them