8000 fix(providers/api/metrics): Report correct error codes in metrics for APIs by nivasan1 · Pull Request #323 · skip-mev/connect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

fix(providers/api/metrics): Report correct error codes in metrics for APIs #323

Merged
merged 31 commits into from
Apr 8, 2024
Merged

fix(providers/api/metrics): Report correct error codes in metrics for APIs #323

merged 31 commits into from
Apr 8, 2024

Conversation

nivasan1
Copy link
Contributor
@nivasan1 nivasan1 commented Apr 5, 2024

No description provided.

aljo242
aljo242 reviewed Apr 5, 2024
View reviewed changes
providers/apis/defi/raydium/types.go
@@ -80,7 +80,7 @@ var DefaultAPIConfig = oracleconfig.APIConfig{
Enabled: true,
Name: Name,
Timeout: 500 * time.Millisecond,
Interval: 100 * time.Millisecond,
Interval: 500 * time.Millisecond,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our current RPC providers, we'll get rate-limited otherwise

@nivasan1 nivasan1 requested a review from aljo242 April 5, 2024 23:09
@nivasan1 nivasan1 force-pushed the nv/fix-metrics-api branch from 10d918a to f839317 Compare April 6, 2024 00:15
@codecov Codecov
Copy link
codecov bot commented Apr 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 62.32%. Comparing base (aab0e63) to head (cd0ee35).

❗ Current head cd0ee35 differs from pull request most recent head 83f4676. Consider uploading reports for the commit 83f4676 to get more accurate results

Files Patch % Lines
cmd/slinky-config/main.go 0.00% 13 Missing ⚠️
providers/apis/defi/raydium/price_fetcher.go 41.17% 7 Missing and 3 partials ⚠️
providers/apis/defi/raydium/multi_client.go 80.95% 7 Missing and 1 partial ⚠️
providers/base/api/metrics/api_query_handler.go 30.00% 7 Missing ⚠️
providers/apis/defi/raydium/options.go 0.00% 3 Missing ⚠️
cmd/client/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   62.48%   62.32%   -0.16%     
==========================================
  Files         222      222              
  Lines        9798     9803       +5     
==========================================
- Hits         6122     6110      -12     
- Misses       3120     3137      +17     
  Partials      556      556

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aljo242
aljo242 reviewed Apr 7, 2024
View reviewed changes
@nivasan1 nivasan1 requested a review from aljo242 April 8, 2024 15:09
@nivasan1 nivasan1 force-pushed the nv/fix-metrics-api branch from cd0ee35 to 83f4676 Compare April 8, 2024 15:15
@nivasan1 nivasan1 changed the base branch from nv/implement-multi-solana-client to main April 8, 2024 15:15
@nivasan1 nivasan1 merged commit 35c352e into main Apr 8, 2024
@zrbecker zrbecker deleted the nv/fix-metrics-api branch November 5, 2024 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eric-Warehime Eric-Warehime Eric-Warehime approved these changes

@aljo242 aljo242 aljo242 approved these changes

@davidterpay davidterpay Awaiting requested review from davidterpay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nivasan1 @Eric-Warehime @aljo242
0