This repository was archived by the owner on Mar 24, 2025. It is now read-only.
chore: Cleaning up deadcode #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
commented
Apr 10, 2024
| @@ -1,79 +1,209 @@ | |||
| package oracle | |||
|
|
|||
| import ( | |||
| "maps" | |||
| "fmt" | |||
There was a problem hiding this comment.
No new code, just renaming and moving to a different file name since it was previously in median.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/market-map-2 #337 +/- ##
=====================================================
- Coverage 56.94% 56.73% -0.22%
=====================================================
Files 228 227 -1
Lines 10767 10756 -11
=====================================================
- Hits 6131 6102 -29
- Misses 4122 4141 +19
+ Partials 514 513 -1 ☔ View full report in Codecov by Sentry. |
aljo242
approved these changes
Apr 10, 2024
aljo242
pushed a commit
that referenced
this pull request
Apr 10, 2024
* new market * gen * fix * wip * dep * ok * tidy * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * init * market query * types * events * proto * module defs * beautify * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * feat(`x/marketmap`): init types and validation (#266) * clean * new market * gen * fix * wip * dep * update * cute * clean * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * comment * expand tests * better errors --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * feat(`x/marketmap`): params type (#267) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * comment * expand tests * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): genesis and validation (#268) * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * feat(`x/marketmap`): keeper methods (#270) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * beautify * merchandise * comment * export func * test * expand tests * fix * bye * fix * fix vuln * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): tx and msg service (#273) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * beautify * merchandise * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * nolint * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): query server (#275) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * beautify * merchandise * fix * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marktmap`): keeper genesis (#276) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * test * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * feat(`x/marketmap`): keeper hooks (#279) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): query cli (#280) * init * market query * fix * feat(`x/marketmap`): events (#281) * types * events --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): add `Admin` param (#293) * add admin * fix * better check * revert * update proto * clean * fix * set * test * fix * test * fix * proto * best * capacity * ok * refactor: Provider Ticker Interface (PR1) (#322) * init * init * remove code that should not be here * remove code that should not be here v2 * testing nit * cr * removing decimals from if * refactor: API Price Providers with Provider Ticker Interface (PR2) (#325) * init * more changes * api providers * more nits * cr * cr 2 * remove dec * refactor: WebSocket Providers with ProviderTickers interface (PR3) (#328) * init * more changes * api providers * more nits * cr * cr 2 * init * nits * factory methods * oracle math done * done with build * done with build * done with dydx basic changes * updating * update * dydx provider done * done with oracle testing * done with providers * build * configs * config nit * nits * update aggregator * refactor: marketmap full conversion (#333) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * fix? * fix * fix * fix * fixed forever * ok * nits * tidy * remove GetProvider * refactor: `mm2` -> `marketmap` (#334) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * temp * bye * gen * fix * fmt * regen mocks * fix? * fix * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> --------- Co-authored-by: Alex Johnson <alex@skip.money> * chore: Cleaning up deadcode (#337) * init * nit * tidy other readmes * more nits * chore: `marketmap` cleanup (#338) * proto * fix * comment * comment out test * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * ok * sure * tidy all * readme --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
beer-1
pushed a commit
to beer-1/slinky
that referenced
this pull request
Apr 11, 2024
* compute gov addr after config changed * Fix type removal * chore(deps): bump github.com/cosmos/ibc-go/v8 in /tests/integration (#320) Bumps [github.com/cosmos/ibc-go/v8](https://github.com/cosmos/ibc-go) from 8.0.0 to 8.2.0. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v8.2.0/CHANGELOG.md) - [Commits](cosmos/ibc-go@v8.0.0...v8.2.0) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <alex@skip.money> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * chore(deps): bump github.com/gagliardetto/solana-go from 1.9.3 to 1.10.0 (#327) Bumps [github.com/gagliardetto/solana-go](https://github.com/gagliardetto/solana-go) from 1.9.3 to 1.10.0. - [Release notes](https://github.com/gagliardetto/solana-go/releases) - [Changelog](https://github.com/gagliardetto/solana-go/blob/main/CHANGELOG.md) - [Commits](gagliardetto/solana-go@v1.9.3...v1.10.0) --- updated-dependencies: - dependency-name: github.com/gagliardetto/solana-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <alex@skip.money> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * chore(deps): bump supplypike/setup-bin from 3 to 4 (#336) Bumps [supplypike/setup-bin](https://github.com/supplypike/setup-bin) from 3 to 4. - [Release notes](https://github.com/supplypike/setup-bin/releases) - [Commits](supplypike/setup-bin@v3...v4) --- updated-dependencies: - dependency-name: supplypike/setup-bin dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * chore(deps): bump github.com/gagliardetto/binary from 0.7.7 to 0.8.0 (#326) Bumps [github.com/gagliardetto/binary](https://github.com/gagliardetto/binary) from 0.7.7 to 0.8.0. - [Release notes](https://github.com/gagliardetto/binary/releases) - [Changelog](https://github.com/gagliardetto/binary/blob/master/CHANGELOG.md) - [Commits](gagliardetto/binary@v0.7.7...v0.8.0) --- updated-dependencies: - dependency-name: github.com/gagliardetto/binary dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <alex@skip.money> * chore(deps): bump google.golang.org/grpc from 1.63.0 to 1.63.2 (#331) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.0 to 1.63.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.63.0...v1.63.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <alex@skip.money> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * chore(deps): bump github.com/klauspost/compress from 1.17.7 to 1.17.8 (#330) Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.17.7 to 1.17.8. - [Release notes](https://github.com/klauspost/compress/releases) - [Changelog](https://github.com/klauspost/compress/blob/master/.goreleaser.yml) - [Commits](klauspost/compress@v1.17.7...v1.17.8) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Johnson <alex@skip.money> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat: `x/marketmap` v2 (#265) * new market * gen * fix * wip * dep * ok * tidy * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * init * market query * types * events * proto * module defs * beautify * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * feat(`x/marketmap`): init types and validation (#266) * clean * new market * gen * fix * wip * dep * update * cute * clean * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * comment * expand tests * better errors --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * feat(`x/marketmap`): params type (#267) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * ok * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * comment * expand tests * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): genesis and validation (#268) * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * feat(`x/marketmap`): keeper methods (#270) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * beautify * merchandise * comment * export func * test * expand tests * fix * bye * fix * fix vuln * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): tx and msg service (#273) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * beautify * merchandise * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * nolint * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): query server (#275) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * beautify * merchandise * fix * fix * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marktmap`): keeper genesis (#276) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * test * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * feat(`x/marketmap`): keeper hooks (#279) * clean * new market * gen * fix * wip * dep * update * cute * clean * params * fix * len * cp * init * ok * cute * add * errors * fix * keeper test * nice * cdc * msg : * msg * clean * update * fix tests * query * query setup * query * query * init hooks * add to keeper * test * add hooks * genesis hook * fix * this is my legacy * ok * lint * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * Update x/mm2/types/market.go Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix * test * newline * remove * test * fix * fix * fix * fix * beautify * merchandise * fix * fix * fix * fix * get params * test * comment * export func * test * invalid bech32 * check * bet * format * expand tests * fix * bye * fix * 0 len * fix * fix vuln * fixington * fix * nolint * check * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): query cli (#280) * init * market query * fix * feat(`x/marketmap`): events (#281) * types * events --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * feat(`x/marketmap`): add `Admin` param (#293) * add admin * fix * better check * revert * update proto * clean * fix * set * test * fix * test * fix * proto * best * capacity * ok * refactor: Provider Ticker Interface (PR1) (#322) * init * init * remove code that should not be here * remove code that should not be here v2 * testing nit * cr * removing decimals from if * refactor: API Price Providers with Provider Ticker Interface (PR2) (#325) * init * more changes * api providers * more nits * cr * cr 2 * remove dec * refactor: WebSocket Providers with ProviderTickers interface (PR3) (#328) * init * more changes * api providers * more nits * cr * cr 2 * init * nits * factory methods * oracle math done * done with build * done with build * done with dydx basic changes * updating * update * dydx provider done * done with oracle testing * done with providers * build * configs * config nit * nits * update aggregator * refactor: marketmap full conversion (#333) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * fix? * fix * fix * fix * fixed forever * ok * nits * tidy * remove GetProvider * refactor: `mm2` -> `marketmap` (#334) * wip * suite * renames * renames * all tests passing * lint pass * fix e2e * temp * bye * gen * fix * fmt * regen mocks * fix? * fix * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> --------- Co-authored-by: Alex Johnson <alex@skip.money> * chore: Cleaning up deadcode (#337) * init * nit * tidy other readmes * more nits * chore: `marketmap` cleanup (#338) * proto * fix * comment * comment out test * fix * fix --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * ok * sure * tidy all * readme --------- Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com> * fix test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Eric <eric.warehime@gmail.com> Co-authored-by: Alex Johnson <alex@skip.money> Co-authored-by: Nikhil Vasan <97126437+nivasan1@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Terpay <35130517+davidterpay@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.