DataClassDecoder: defer null/undefined handling #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DataClassDecoder` extends the `NullHandlingDecoder`, so with undefined input the data class decoder never actually executes -- the `NullHandlingDecoder` kicks out the undefined immediately, resulting in a missing config error. Prefixes make this much more likely to happen because there is almost always defined (but irrelevant) config at the root e.g. env vars, properties, etc -- thus giving the `DataClassDecoder` a chance to do its thing with defaults -- but prefixed config is much more likely to be completely `Undefined`. Resolves sksamuel#480
240f9e2 to
fab74f2
Compare
|
@sksamuel any chance that we could still get a 2.x release with this fix included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DataClassDecoderextends theNullHandlingDecoder, so with undefined input the data class decoder never actually executes, even if the data class provides defaults -- theNullHandlingDecoderkicks out the undefined immediately, resulting in missing config errors.Prefixes make this much more likely to happen because there is almost always defined (but irrelevant) config at the root e.g. env vars, properties, etc -- thus giving the
DataClassDecodera chance to do its thing with defaults -- but prefixed config is much more likely to be completelyUndefined.Resolves #480