Add selector user guide #1419
Add selector user guide #1419
Conversation
2b9de03 to
4610cfc
Compare
doc/selectors.rst
Outdated
| - Delayed selection: passing a selection rule, to be evaluated later on a | ||
| dataframe that is not yet available. For example, without selectors | ||
| it is not possible to instantiate a :class:`~skrub.SelectCols` that selects "all | ||
| columns that have numerical data types, except the column ``'User ID'``", if the |
There was a problem hiding this comment.
I am not very convinced by this example. How about using datetime columns that haven't yet been parsed as datetimes? So they'd start as strings, and the selector for dates would not recognize them as such.
There was a problem hiding this comment.
better? "all columns except those with the suffix 'ID'"
There was a problem hiding this comment.
to me the delayed selection is important when there are transformations that add or modify columns so that they're different from the input, so casting to a different datatype or maybe generating features with one of the encoders (which is why I mentioned datetimes)
"all columns except those with the suffix ID" looks to me like something that could be done immediately
There was a problem hiding this comment.
Thanks a lot for the PR @Vincent-Maladiere
I made a few comments, mostly to reword a few sentences.
| dataframes: | ||
|
|
||
| >>> import pandas as pd | ||
| >>> df = pd.DataFrame( |
There was a problem hiding this comment.
I'm wondering if there should be a line explaining that "this is a dataset about page sizes", I find it a bit unusual and did not understand what the numbers were saying the first read through
|
In this PR or a separate one? |
|
Maybe in a separate one? |
|
waiting for @GaelVaroquaux to have a quick look before merging |
|
@GaelVaroquaux mentioned in the weekly meeting that this and other doc PRs should be iterated over, so we can merge it and open new PRs as needed |
Fixes #1382