[MNT] URLs changed on CRAN; updated _fpp3_loaders.py accordingly #7084
Conversation
|
we could also upload the data to the |
|
With help from GitHub Copilot, here is a sample test function to be added to the test suite. Please suggest changes or explain where this test function should be placed so that it becomes part of the "full test suite". Thanks |
|
I responded to this request with sample test. Please advise if this is an ok test and where to place it. Thanks |
|
Hm, looks good with one minor issue: if we do it this way, we would have to update the dataset URL in two places, and if one changes it in only one place (e.g., next time we need to update), the test will no longer work. We should hence use |
|
Good point about the duplication of the url's. Fixed. Good catch. Released. |
FPP3 datasets are loaded from CRAN, using fixed URLs. CRAN updated two
of the three URLs used by _fpp3_loaders.py. This PR updates the URLs
accordingly (otherwise the functionality is broken.)
A reviewer can run the following code to test the change, if desired.
```
import matplotlib.pyplot as plt
from sktime.datasets import load_fpp3
from sktime.utils.plotting import plot_series
y = load_fpp3('aus_production')['Beer']
fig, ax = plot_series(y)
plt.show()
```
FPP3 datasets are loaded from CRAN, using fixed URLs. CRAN updated two of the three URLs used by _fpp3_loaders.py. This PR updates the URLs accordingly (otherwise the functionality is broken.)
A reviewer can run the following code to test the change, if desired.