[MNT] python 3.13 support in pyproject.toml and CI
#7198
Conversation
pyproject.tomlpyproject.toml and CI
pyproject.toml
Outdated
There was a problem hiding this comment.
I hope I am wrong, but I don't remember seeing a dependabot update for a python package that is specified with a restriction on python version. I am concerned that it may essenttially disable Dependabot, and will need manual check for every single package to update in future.
There was a problem hiding this comment.
hm, I am not sure - possibly.
But even with the other packages we have the problem that dependabot updates incorrectly, e.g., only one occurrence in one soft dep set.
It is either adding these restrictions, or not releaseing a python 3.13 compatible version in 2024.
There was a problem hiding this comment.
(or, do you see another option?)
There was a problem hiding this comment.
I am not on laptop, but if we try to install a bunch packages in python 3.13 whete not all of them supports it, does it fail fast or try all and then report all the failing ones? If latter, we can use that.
Basically my suggestion is to not add any, run 3.13 only CI, check error log, add only for those, run full CI.
There was a problem hiding this comment.
unfortunately, on attempted install, only the first incompatible install attepmt is reported, and the install fails. Are you suggesting another option? If so, PR appreciated.
This PR is an upgrade of `pyproject.toml` to allow python 3.13. Soft dependencies are all conditioned on python < 3.13, this can be relaxed as soft dependencies start supporting python 3.13. This also adds 3.13 in the CI. For release with `sktime 0.34.0`, not to be merged until python 3.13 is released and compatibility is tested.
This PR is an upgrade of
pyproject.tomlto allow python 3.13.Soft dependencies are all conditioned on python < 3.13, this can be relaxed as soft dependencies start supporting python 3.13.
This also adds 3.13 in the CI.
For release with
sktime 0.34.0, not to be merged until python 3.13 is released and compatibility is tested.