[ENH] Added get_test_params in ThetaLinesTransformer #7199
Conversation
|
Yes, sure |
|
I have added an empty |
There was a problem hiding this comment.
Thanks!
Now the code needs to be formatted correctly, e.g., black formatted, see here how to automate this:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html
Or, inspect the failed linting test for suggestions.
|
I have formatted the code as per the guidelines. |
| parameter_set : str, default="default" | ||
| Name of the set of test parameters to return, for use in tests. If no | ||
| special parameters are defined for a value, will return | ||
| de_types.pyfault"` set. |
There was a problem hiding this comment.
check now
There was a problem hiding this comment.
if should be "default", no?
There was a problem hiding this comment.
Just to confirm, when you mentioned "if should be 'default'," are you suggesting that the empty dictionary should only be returned if parameter_set == 'default'? For example:
if parameter_set == "default":
return [{}]
else:
return [{"theta": (0, 2)}, {"theta": (0.5, 1.5)}]
There was a problem hiding this comment.
no, I mean, the docstring has a typo with some incomprehensible words instead of the word "default" - the code is fine
There was a problem hiding this comment.
I changed the typo and kept it comprehensible.
This PR adds the get_test_params method to the ThetaLinesTransformer class, providing standardized parameter settings for testing. This change implements the get_test_params method, which returns a list of dictionaries containing test parameters for the ThetaLinesTransformer. This will facilitate easier testing and validation of the transformer’s functionality.
This PR adds the get_test_params method to the ThetaLinesTransformer class, providing standardized parameter settings for testing.
What does this implement/fix? Explain your changes.
This change implements the get_test_params method, which returns a list of dictionaries containing test parameters for the ThetaLinesTransformer. This will facilitate easier testing and validation of the transformer’s functionality.
Does your contribution introduce a new dependency? If yes, which one?
No new dependencies were introduced.
What should a reviewer concentrate their feedback on?
The implementation of the get_test_params method
The clarity of the parameter settings provided for testing
Did you add any tests for the change?
Yes, relevant tests have been added to ensure the functionality of get_test_params.