[BUG] Prophet not tagged as "handles-missing-data" #7267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prophet is able to handle missing data, but it is wrongly tagged so far.
|
Hi @Garve, thanks for your contribution. I have initiated CI in this PR, but it seems fair to have a dedicated unit test for missing value support specifically for |
|
I was also thinking that, but I was considering more along the lines of for all estimators that claim to support missing data. How I would do it:
(in case you still are worried about the contribution being too small, @Garve 😁) |
fkiraly
previously approved these changes
Oct 18, 2024
benHeid
pushed a commit
that referenced
this pull request
Feb 15, 2025
Prophet is able to handle missing data, but it is wrongly tagged so far. Fixes #7266. #### What does this implement/fix? Explain your changes. I just set the tag to `True`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prophet is able to handle missing data, but it is wrongly tagged so far.
Fixes #7266.
What does this implement/fix? Explain your changes.
I just set the tag to
True.Does your contribution introduce a new dependency? If yes, which one?
No.
Did you add any tests for the change?
No.
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
maintainerstag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.